Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow validators to delegate part of their epoch payment #8993

Merged
merged 12 commits into from
Jan 6, 2022

Conversation

m-chrzan
Copy link
Contributor

@m-chrzan m-chrzan commented Nov 19, 2021

Description

This change allows validators to specify an address that will receive a fraction of each of their epoch payments, allowing e.g. regular donations of part of their payments.

Other changes

Added the to != address(0) check to MockStableToken's mint function to ensure the real StableToken's behavior is correctly replicated.

Tested

Unit tests.

Related issues

Backwards compatibility

New functions and storage variables added. No backwards compatibility breaking changes.

@m-chrzan m-chrzan requested a review from a team November 19, 2021 16:03
Copy link
Contributor

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, 1 question about full rewards delegation

packages/protocol/contracts/common/Accounts.sol Outdated Show resolved Hide resolved
@m-chrzan m-chrzan added the automerge Have PR merge automatically when checks pass label Jan 6, 2022
@mergify mergify bot merged commit d7c8936 into master Jan 6, 2022
@mergify mergify bot deleted the m-chrzan/payment-delegation branch January 6, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate validator/voter rewards delegation
2 participants